Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Devstack: Make boot volume optional on openstack #2315

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

This makes it possible to choose if the devstack should be created with or without volumes when running on openstack. It also bumps the default image name to ubuntu-2404-lts to match the other resource types.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

This makes it possible to choose if the devstack should be created with
or without volumes when running on openstack. It also bumps the default
image name to ubuntu-2404-lts to match the other resource types.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit b45c700
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67596f0c35d19000082ccd2b
😎 Deploy Preview https://deploy-preview-2315--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 11e371b into kubernetes-sigs:main Dec 11, 2024
9 checks passed
@EmilienM
Copy link
Contributor

@lentzi90 I'll propose the backports. Note that 0.9 backport should be cherry picked into #2306 or wait for it to be merged and then run the bot to backport it.

/cherry-pick release-0.11 release-0.10
0.9 will come later as I said

@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2317

In response to this:

@lentzi90 I'll propose the backports. Note that 0.9 backport should be cherry picked into #2306 or wait for it to be merged and then run the bot to backport it.

/cherry-pick release-0.11 release-0.10
0.9 will come later as I said

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90 lentzi90 deleted the lentzi90/devstack-openstack-optional-volume branch December 11, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants