Update Go to v1.21

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates golang to v1.21 to match CAPI:

• 🌱 Bump Go to 1.21.5 cluster-api#9900

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

See #3478 for prior art.

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[mboersma]

I'm assuming we also need to update testgrid e2e jobs for a newer container with Go 1.21. Kind of a chicken-and-egg situation...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.72%. Comparing base (7f385fd) to head (ff7916f).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4529      +/-   ##
==========================================
- Coverage   62.73%   62.72%   -0.02%     
==========================================
  Files         192      192              
  Lines       15644    15644              
==========================================
- Hits         9815     9813       -2     
- Misses       5146     5148       +2     
  Partials      683      683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nawazkh]

I'm assuming we also need to update testgrid e2e jobs for a newer container with Go 1.21. Kind of a chicken-and-egg situation...

Does that mean we are merging this PR first and updating e2e jobs later on? Or is it the other way round?

[mboersma]

Does that mean we are merging this PR first and updating e2e jobs later on?

I don't know actually. I'm not sure what we did in previous situations, have to do some research.

[mboersma]

/retest

Just trying to get another read on #4553.

[Jont828]

Test seems to be failing b/c the go version is 1.20:

Detected go version: go version go1.20.13 linux/amd64.
Kubernetes requires go1.21.6 or greater.
Please install go1.21.6 or later.

[nojnhuh]

I'm assuming we also need to update testgrid e2e jobs for a newer container with Go 1.21. Kind of a chicken-and-egg situation...

It looks like our kubekins image pulls in Go 1.21 now:

% docker run --rm --entrypoint go -it gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240219-207a9fb4d2-1.27 version
go version go1.21.7 linux/amd64

[nojnhuh]

While CAPI's main branch now uses Go 1.21, CAPI's 1.6 branch is still using Go 1.20, so it might be best to stay where we're at until we bump to CAPI 1.7 if we don't have any other need to upgrade.

/hold

[mboersma]

/hold cancel

/assign @nojnhuh

This needs to merge before we can incorporate CAPI v1.7.0-beta.0, because note: module requires Go 1.21.

I've been using Go 1.21 to work with CAPZ in general, so I think it's safe to bump up to that version while still having CAPI 1.6 in main.

[nojnhuh]

/lgtm

[nojnhuh]

Not something we have to address now, but I'm wondering if we need this script at all since I think the go directive in go.mod already enforces this everywhere we'd need. I imagine this script was probably added to k/k like 8 years ago before Go modules and we inherited it from there.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4a4e83200d6b8e78feaaf557934a6bd521addb9b

[nojnhuh]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2873ad17ed9e198fb83acac220639de28ccecb8b

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment