add pause handling for AzureMachine, AzureManagedMachinePool, AzureMachinePool #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XL
|
(squash reminder) |
k8s-ci-robot
added
the
do-not-merge/hold
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
+ Coverage 54.86% 55.18% +0.32%
==========================================
Files 188 188
Lines 19348 19427 +79
==========================================
+ Hits 10615 10721 +106
+ Misses 8151 8111 -40
- Partials 582 595 +13
☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
needs-rebase
|
/assign |
mboersma
reviewed
Aug 10, 2023
|
/retest |
1 similar comment
|
/retest |
mboersma
reviewed
Aug 11, 2023
| @@ -1310,3 +1311,214 @@ func Test_ManagedMachinePoolToInfrastructureMapFunc(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestClusterPauseChangeAndInfrastructureReady(t *testing.T) { | |||
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 277b94ccf39f98172f28bcd856a01b4d130669d1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
nojnhuh
force-pushed
the
aso-pause-controllers
branch
from
fb83d3d to
22fa554
Compare
|
squashed! |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR follows up from #3735 and #3783 to set up the remaining controllers to handle pausing ASO resources when the parent Cluster is paused. These changes aren't strictly necessary until more services are re-implemented to use ASO, but I figured it would be worth merging ahead of time so we don't have to remember to do that later.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #3525
Special notes for your reviewer:
TODOs:
Release note: