Improve Pre-commit UX

[nawazkh]

/kind cleanup

What needs cleanup:
Pre-commit UX can be improved.

Describe the solution you'd like

• As of this issue creation, pre-commit does not run unit tests and linter locally.
• While running local unit tests and linter on every commit hindered the commit speed, I have noticed that I would rather have them run locally than discovering them as a blocker on a PR after an hour of raising the PR.
• So upon exploring pre-commit documentation, I came across "Confining hooks to run at certain stages" where we can potentially configure make verify and make test to run either stage:manually or on stage: pre-push.
  • Setting the make verify test at stage:manual will not trigger it from running it locally on git commands. Instead it will only get triggered on pre-commit run <my-hook> --hook-stage manual
  • Setting make verify test at stage:pre-push will trigger the hook on running git push. This seems more helpful and a good trade off between dev speed and optimal coverage.
• Considering that we stick with stage:pre-push we want to ensure we can skip running make test verify by appending --no-verify to git push command.

[bryan-cox]

Hey @nawazkh 👋🏻 - I can take a look at this one.

/assign

[nawazkh]

Reopening this because pre-push stage is crashing my local. Something is happening, need to investigate.
Is anyone else seeing this behavior in their local ?

Until this is fixed, if using pre-commit framework, please use git push --no-verify to push changes to origin.

/reopen

[k8s-ci-robot]

@nawazkh: Reopened this issue.

In response to this:

Reopening this because pre-push stage is crashing my local. Something is happening, need to investigate.
Is anyone else seeing this behavior in their local ?

Until this is fixed, if using pre-commit framework, please use git push --no-verify to push changes to origin.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nawazkh]

Hi @bryan-cox , since you were already assigned to this issue, reopening this issue must have pinged you. Please feel free to un-assign yourself in case you don't wanna pick this up. :)