🌱 Avoid panicking in after-suite test code, improve logging

[AndiDog]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If a test failed, the dumping code may not have AWS clients yet and then panicked. This shifts the attention to a large stack trace instead of the actual, previous failures.

Also some logging improvements: start sentences with uppercase, use newlines.

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndiDog]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[dlipovetsky]

Changes look good. Is there an infrastructure issue causing the e2e to fail?

/usr/lib/python3/dist-packages/requests/__init__.py:109: RequestsDependencyWarning: urllib3 (2.3.0) or chardet (5.1.0)/charset_normalizer (3.0.1) doesn't match a supported version!
  warnings.warn(
Traceback (most recent call last):
  File "/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/hack/boskos.py", line 112, in <module>
    main()
  File "/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/hack/boskos.py", line 102, in main
    checkout_account(args.resource_type, args.user)
  File "/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/hack/boskos.py", line 42, in checkout_account
    raise Exception(f"Got invalid response {r.status_code}: {r.reason}")
Exception: Got invalid response 404: Not Found
+ EXIT_VALUE=1
+ set +o xtrace
Cleaning up after docker in docker.

[AndiDog]

@dlipovetsky This error happens frequently. I see that in CAPG, the resource is freed in case of HTTP 404 (code), but I don't understand enough of Boskos or this workaround to be helpful.

[richardcase]

/test pull-cluster-api-provider-aws-e2e

[k8s-ci-robot]

@AndiDog: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-e2e-eks	8a30d1a	link	false	/test pull-cluster-api-provider-aws-e2e-eks
pull-cluster-api-provider-aws-e2e	8a30d1a	link	false	/test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[fiunchinho]

/lgtm