Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ⚠️ aws-sdk-go-v2 refactor starting with s3 #5272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: ⚠️ aws-sdk-go-v2 refactor starting with s3 #5272

wants to merge 1 commit into from

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jan 10, 2025 •
edited
Loading

What type of PR is this?
/kind feature
/kind cleanup

What this PR does / why we need it:
Just sharing how the aws-sdk-go-v2 refactor is going to allow for discussion when needed

Which issue(s) this PR fixes:
Part of #2225

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Migrate the S3 service to aws-sdk-go-v2

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
mjlshen
mjlshen commented Jan 10, 2025
View reviewed changes
pkg/cloud/services/s3/mock_s3iface/doc.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth calling out, it's now straightforward to unit test AWS clients without gomock https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/unit-testing.html, but I chose to keep doing so for now to limit the breadth of changes. Happy to start refactoring gomock away from the AWS servicces in a follow up PR if that sounds good.

@mjlshen mjlshen force-pushed the aws-sdk-go-v2 branch 3 times, most recently from e4f9e6e to 5b59d63 Compare January 10, 2025 06:03
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2025
@mjlshen mjlshen changed the title WIP: aws-sdk-go-v2 refactor starting with s3 WIP: ⚠️ aws-sdk-go-v2 refactor starting with s3 Jan 11, 2025
@mjlshen
Start refactoring the s3 client to aws-sdk-go-v2
b6905f4 
Signed-off-by: Michael Shen <mishen@umich.edu>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2025 •
edited
Loading

@mjlshen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main b6905f4 link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo Awaiting requested review from damdo

@richardcase richardcase Awaiting requested review from richardcase

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjlshen @k8s-ci-robot