Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.6] ✨refactor: update to use new community ami account #5177

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Manual cherry-pick of #5133

Updates to the project to start using the new CNCF owned AWS account for publishing AMIs. The code has had the old VMWare account removed and the new account ID added. Additionally the docs have been updated including clarifying that the public AMIs should only be used for non-production usage.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relates #5131
Relates #4984

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

action required
A new community owned AWS account is now being used for publishing AMIs. The old account owner by a company is no longer accessible and the images are being automatically deleted by AWS. Support for ubuntu 18.04 & 20.04 has been dropped and ubuntu 24.04 is now the default OS if no OS is supplied.

Updates to the project to start using the new CNCF owned AWS account
for publishing AMIs. The code has had the old VMWare account removed
and the new account ID added. Additionally the docs have been updated
including clarifying that the public AMIs should only be used for
non-production usage.

Signed-off-by: Richard Case <richard.case@outlook.com>
This make changes to the developer and user documentation. And also
updates the k8s version used in the e2e test to a version where we have
an AMI available.

Signed-off-by: Richard Case <richard.case@outlook.com>
This updates the kubernetes versions used in the e2e tests to use k8s
versions that we AMIs for. It also marks some of the old CSI tests as
pending and some upgrade tests as pending (which will be re-enabled
at a later time).

A few minor docs updates have been made as a result of review.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from richardcase. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nrb October 23, 2024 15:36
@k8s-ci-robot k8s-ci-robot added needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 23, 2024
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member Author

We have no e2e jobs configured for this release branch

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-build-docker-release-2-6
  • /test pull-cluster-api-provider-aws-build-release-2-6
  • /test pull-cluster-api-provider-aws-test-release-2-6
  • /test pull-cluster-api-provider-aws-verify-release-2-6

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-gc-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-testing-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-release-2-6

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-2-6
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-build-docker-release-2-6
  • pull-cluster-api-provider-aws-build-release-2-6
  • pull-cluster-api-provider-aws-test-release-2-6
  • pull-cluster-api-provider-aws-verify-release-2-6

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-release-2-6

1 similar comment
@damdo
Copy link
Member

damdo commented Oct 24, 2024

/test pull-cluster-api-provider-aws-e2e-release-2-6

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-release-2-6 4171551 link false /test pull-cluster-api-provider-aws-e2e-release-2-6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@richardcase
Copy link
Member Author

I think we can consider closing this and just going with a v2.7.0 release. Until we decide:

/hold

@richardcase
Copy link
Member Author

As v2.7.1 is out:

/close

@k8s-ci-robot
Copy link
Contributor

@richardcase: Closed this PR.

In response to this:

As v2.7.1 is out:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. needs-priority release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants