🌱 chore: change name of prevent deletion label #5072
Conversation
Small change to prefix the label that preevents deletion of the VPC CNI to be prefixed with an CAPA prefix. This is just to ensure that we make it as specific to CAPA as possible. Signed-off-by: Richard Case <richard.case@outlook.com>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/S
richardcase
changed the title
k8s-ci-robot
added
release-note
|
/milestone v2.6.0 |
|
/test pull-cluster-api-provider-aws-test |
|
@jas-nik: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-2.6 |
|
/cherrypick release-2.6 |
|
@richardcase: new pull request created: #5073 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@richardcase: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-aws#release-2.6 from head k8s-infra-cherrypick-robot:cherry-pick-5072-to-release-2.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-5072-to-release-2.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Small change to prefix the label that prevents deletion of the VPC CNI to be prefixed with an CAPA prefix. This is just to ensure that we make it as specific to CAPA as possible.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This is a follow-up to #5009 . I thought about this after it merged.
@jas-nik - would love to get your thoughts on making the label name more specific to CAPA.
Checklist:
Release note: