Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.4] 🐛 fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts #4921

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[release-2.4] 🐛 fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts #4921

merged 1 commit into from
Apr 11, 2024

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Apr 11, 2024 •
edited by damdo
Loading

This is a manual backport from #4841

Fix instance PrivateDNSName when domain-name is set in dhcpOpts

@jparrill
OCPBUGS-29391: Fix instance PrivateDNSName when domain-name is set in…
362a226 
… dhcpOpts

When a VPC sets a DHCPOption's domain-name with a custom DNS name, it's being ignored. Now, with this PR, ensure that during instance creation, the controller checks the DHCPOptions and sets the proper PrivateDNSName.

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jparrill. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@damdo
Copy link
Member

damdo commented Apr 11, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2024
@jparrill jparrill changed the title OCPBUGS-29391: Fix instance PrivateDNSName when domain-name is set in… fix: Fix instance PrivateDNSName when domain-name is set in… Apr 11, 2024
@jparrill
Copy link
Contributor Author

/test "PR verify"

@k8s-ci-robot
Copy link
Contributor

@jparrill: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-build-docker-release-2-4
  • /test pull-cluster-api-provider-aws-build-release-2-4
  • /test pull-cluster-api-provider-aws-test-release-2-4
  • /test pull-cluster-api-provider-aws-verify-release-2-4

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-eks-gc-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-eks-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-eks-testing-release-2-4
  • /test pull-cluster-api-provider-aws-e2e-release-2-4

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-2-4
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-build-docker-release-2-4
  • pull-cluster-api-provider-aws-build-release-2-4
  • pull-cluster-api-provider-aws-test-release-2-4
  • pull-cluster-api-provider-aws-verify-release-2-4

In response to this:

/test "PR verify"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill jparrill changed the title fix: Fix instance PrivateDNSName when domain-name is set in… [release-2.4] 🐛 fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2024
@damdo damdo mentioned this pull request Apr 11, 2024
Closed
damdo
damdo reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@damdo
Copy link
Member

damdo commented Apr 11, 2024

/assign @richardcase

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1c23009 into kubernetes-sigs:release-2.4 Apr 11, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@richardcase richardcase

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jparrill @k8s-ci-robot @damdo @richardcase