🐛 fix/network/rtb: delete rtb handling err when failed to create routes

[mtulio]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fix creates an error handler when the route table reconcile loop returns error when creating routes. It will prevent left the route table behind.

Currently this issue is triggered when an invalid route entry is added, creating a new stale table every new reconciliation, growing to hundreds in a few minutes. This is one example triggering the issue (a subset of Carrier Gateway support adding in #4901):

E0403 01:04:42.329759 1157154 awscluster_controller.go:327] "failed to reconcile network" err=<
	failed to create route in route table "rtb-067f352c09371fe71": {
	  CarrierGatewayId: "cagw-0ac129c044b2cd1b6",
	  DestinationCidrBlock: "0.0.0.0/0"
	}: MissingParameter: The request must contain exactly one of gatewayId, natGatewayId, networkInterfaceId, vpcPeeringConnectionId, egressOnlyInternetGatewayId, transitGatewayId, localGatewayId, carrierGatewayId, vpcEndpointId, coreNetworkArn or instanceId
		status code: 400, request id: 570b91c9-e228-4ee9-a939-1f5fe0313165

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation (N/A)
• includes emojis
• adds unit tests
• adds or updates e2e tests (N/A)

Release note:

Fix the error handling by deleting the created route table on errors when creating routes.

[k8s-ci-robot]

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtulio]

/assign @vincepri

[mtulio]

@vincepri @damdo would you mind to stamp labels to test?

[damdo]

/ok-to-test

[mtulio]

/test pull-cluster-api-provider-aws-e2e

[mtulio]

/assign @damdo

e2e passing. Unsure why GH checks failed (no logs).

I am happy to introduce units for those functions. Let me know if that approach is feasible before writing more code.

[damdo]

Left a comment but the approach LGTM.
I think, yes, if you can add a unit test that covers this, it would be great.
Thanks!

[mtulio]

Left a comment but the approach LGTM. I think, yes, if you can add a unit test that covers this, it would be great. Thanks!

@damdo unit tests added, and everything is passing now.

[damdo]

Thanks @mtulio
/lgtm

Assigning approvers
/assign @dlipovetsky @vincepri @richardcase @Ankitasw

[damdo]

/test pull-cluster-api-provider-aws-e2e

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/cherry-pick release-2.4

[k8s-infra-cherrypick-robot]

@damdo: new pull request created: #4912

In response to this:

/cherry-pick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.