-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 chore: add docker build to ci #4834
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
On further thought this needs to me changed /hold |
This script will be used by prow to test our docker builds that are an essential part of the release the process. We have encountered an issue where we aren't testing the different architectures. Signed-off-by: Richard Case <richard.case@suse.com>
9e4989a
to
7db9ab6
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This adds a new ci script that will be used by prow to test the docker builds of the controller-manager and clusterawsadm for all supported architectures so that we catch any issues with the builds. Currently we aren't covering all the architectures in the CI
There will be a new prow pre-submit that will call this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Relates #4835
Special notes for your reviewer:
Checklist:
Release note: