Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for AlternativeGCStrategy #4328

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

wyike
Copy link
Contributor

@wyike wyike commented Jun 12, 2023

What type of PR is this?
/kind support

What this PR does / why we need it:

Add two e2e for AlternativeGCStrategy feature

  • [managed] [gc] should cleanup a cluster that has ELB/NLB load balancers using AlternativeGCStrategy
  • [unmanaged] [gc] should cleanup a cluster that has ELB/NLB load balancers using AlternativeGCStrategy

They have exact same test steps with [managed] [gc] should cleanup a cluster that has ELB/NLB load balancers and [unmanaged] [gc] should cleanup a cluster that has ELB/NLB load balancers, except that before creating workload cluster, shared.ReconfigureDeployment is executed to reconfigure capa deployment with AlternativeGCStrategy feature flag set to true and will recover capa after test is done

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4161

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add E2E tests for AlternativeGCStrategy

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2023
@wyike wyike mentioned this pull request Jun 12, 2023
4 tasks
@wyike
Copy link
Contributor Author

wyike commented Jun 12, 2023

/test pull-cluster-api-provider-aws-e2e-eks-gc

@Ankitasw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 63f6fd7 into kubernetes-sigs:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] Add e2e test for AlternativeGCStrategy feature gate
3 participants