chore: Bump golangci-lint to v1.53.2 #4326
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
size/L
Ankitasw
force-pushed
the
golangci-lint-bump
branch
2 times, most recently
from
8f5e18c to
a4af502
Compare
Ankitasw
force-pushed
the
golangci-lint-bump
branch
from
a4af502 to
70b90f3
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
PR is ready for review. |
|
Gentle reminder for review |
| @@ -214,14 +215,14 @@ func (r *AWSMachinePoolReconciler) reconcileNormal(ctx context.Context, machineP | |||
| if !machinePoolScope.Cluster.Status.InfrastructureReady { | |||
| machinePoolScope.Info("Cluster infrastructure is not ready yet") | |||
| conditions.MarkFalse(machinePoolScope.AWSMachinePool, expinfrav1.ASGReadyCondition, infrav1.WaitingForClusterInfrastructureReason, clusterv1.ConditionSeverityInfo, "") | |||
| return ctrl.Result{}, nil | |||
| return ctrl.Result{Requeue: true}, nil | |||
There was a problem hiding this comment.
why is this returning true now? that would active the rate limiter, wouldn't this be just requeue when a change in the status triggers and event?
There was a problem hiding this comment.
Done it based on discussion here: #4321 (comment)
| } | ||
|
|
||
| // Make sure bootstrap data is available and populated | ||
| if machinePoolScope.MachinePool.Spec.Template.Spec.Bootstrap.DataSecretName == nil { | ||
| machinePoolScope.Info("Bootstrap data secret reference is not yet available") | ||
| conditions.MarkFalse(machinePoolScope.AWSMachinePool, expinfrav1.ASGReadyCondition, infrav1.WaitingForBootstrapDataReason, clusterv1.ConditionSeverityInfo, "") | ||
| return ctrl.Result{}, nil | ||
| return ctrl.Result{RequeueAfter: time.Minute}, nil |
There was a problem hiding this comment.
|
dropped a few questions lgtm otherwise |
|
Bumping this again, for pending review. |
|
@richardcase can you take a look at this? |
Ankitasw
requested review from
AverageMarcus
and removed request for
luthermonson
What type of PR is this?
/kind support
What this PR does / why we need it:
bump golangci-lint to v1.53.2 and fix errors related to that.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Comments Originally posted by @richardcase in #4321 (review) addressed. For one of the comments: Originally posted by @Ankitasw in #4321 (comment)
Checklist:
Release note: