-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: building release-binaries fails #4306
fix: building release-binaries fails #4306
Conversation
When doing the v2.1.3 there was an error when building the release binaries. Specifically the `release-binary` task was failing with the following error: ``` error obtaining vcs status exit status 128 ``` Signed-off-by: Richard Case <richard.case@outlook.com>
/cherrypick release-2.1 |
@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-2.0 |
@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Skarlso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@richardcase: new pull request created: #4310 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@richardcase: new pull request created: #4311 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind support
What this PR does / why we need it:
When doing the v2.1.3 there was an error when building the release binaries. Specifically the
release-binary
task was failing with the following error:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Thanks to @killianmuldoon for the change in CAPI that we are using here.
Checklist:
Release note: