Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero csi driver aws credentials to fallback to use instance profile role #4262

Merged
merged 1 commit into from
May 11, 2023
Merged

Zero csi driver aws credentials to fallback to use instance profile role #4262

merged 1 commit into from
May 11, 2023

Conversation

wyike
Copy link
Contributor

@wyike wyike commented May 10, 2023 •
edited by Ankitasw
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:

Based on #4250, we can zero csi driver aws credentials to fallback to use instance profile role, which is a more practical user scenario.
In addition, we need to pin csi controller deployment to control plane, which is explained in #4260 (comment).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4260

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

[E2E] Zero csi driver aws credentials to fallback to use control plane instance profile role for external csi tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels May 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from luthermonson May 10, 2023 17:47
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 10, 2023
@wyike
Copy link
Contributor Author

wyike commented May 10, 2023

/test pull-cluster-api-provider-aws-e2e

@wyike
Copy link
Contributor Author

wyike commented May 11, 2023 •
edited
Loading

All tests are passed, even for the MHC tests. @Skarlso @Ankitasw . Could you help review and approve, thanks!

@Skarlso
Copy link
Contributor

Skarlso commented May 11, 2023

Nice
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@Skarlso
Copy link
Contributor

Skarlso commented May 11, 2023

Eh what the heck is jobs pages.

@Skarlso
Copy link
Contributor

Skarlso commented May 11, 2023

Oh the job called Pages. Uuuh.

@Ankitasw
Copy link
Member

It's still running 😨

@Ankitasw Ankitasw merged commit 0d6f023 into kubernetes-sigs:main May 11, 2023
@Ankitasw
Copy link
Member

Thanks @wyike, this helped solve the issue with E2E tests.

@Skarlso
Copy link
Contributor

Skarlso commented May 11, 2023

Hahaha, that's fantastic. :D

@wyike
Copy link
Contributor Author

wyike commented May 22, 2023

/cherry-pick release-2.1

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 22, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@wyike: new pull request created: #4279

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@Skarlso Skarlso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E2E] Zero csi driver aws credentials to fallback to use instance profile role
5 participants
@wyike @Skarlso @k8s-ci-robot @Ankitasw @k8s-infra-cherrypick-robot