Merge pull request #4287 from Skarlso/fix-field-validation-for-tcp

fix: correct the enum types for protocol values
kubernetes-sigs · May 23, 2023 · 9060eaa · 9060eaa
2 parents 8a2e6b7 + 94c3a6b
commit 9060eaa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/api/v1beta2/network_types.go b/api/v1beta2/network_types.go
@@ -94,7 +94,7 @@ var (
 	TargetGroupAttributeEnablePreserveClientIP = "preserve_client_ip.enabled"
 )
 
-// LoadBalancerAttribute defines a set of attributes for a V2 load balancer
+// LoadBalancerAttribute defines a set of attributes for a V2 load balancer.
 type LoadBalancerAttribute string
 
 var (
@@ -110,7 +110,7 @@ type TargetGroupSpec struct {
 	Name string `json:"name"`
 	// Port is the exposed port
 	Port int64 `json:"port"`
-	// +kubebuilder:validation:Enum=tcp;tls;upd
+	// +kubebuilder:validation:Enum=tcp;tls;udp;TCP;TLS;UDP
 	Protocol ELBProtocol `json:"protocol"`
 	VpcID    string      `json:"vpcId"`
 	// HealthCheck is the elb health check associated with the load balancer.

diff --git a/config/crd/bases/controlplane.cluster.x-k8s.io_awsmanagedcontrolplanes.yaml b/config/crd/bases/controlplane.cluster.x-k8s.io_awsmanagedcontrolplanes.yaml
@@ -1213,7 +1213,10 @@ spec:
                                   enum:
                                   - tcp
                                   - tls
-                                  - upd
+                                  - udp
+                                  - TCP
+                                  - TLS
+                                  - UDP
                                   type: string
                                 targetGroupHealthCheck:
                                   description: HealthCheck is the elb health check
@@ -2639,7 +2642,10 @@ spec:
                                   enum:
                                   - tcp
                                   - tls
-                                  - upd
+                                  - udp
+                                  - TCP
+                                  - TLS
+                                  - UDP
                                   type: string
                                 targetGroupHealthCheck:
                                   description: HealthCheck is the elb health check

diff --git a/config/crd/bases/infrastructure.cluster.x-k8s.io_awsclusters.yaml b/config/crd/bases/infrastructure.cluster.x-k8s.io_awsclusters.yaml
@@ -1677,7 +1677,10 @@ spec:
                                   enum:
                                   - tcp
                                   - tls
-                                  - upd
+                                  - udp
+                                  - TCP
+                                  - TLS
+                                  - UDP
                                   type: string
                                 targetGroupHealthCheck:
                                   description: HealthCheck is the elb health check
-Original file line number
+Diff line change
@@ Expand Up / @@ -1677,7 +1677,10 @@ spec: @@
                                       enum:
                                       - tcp
                                       - tls
-                                      - upd
+                                      - udp
+                                      - TCP
+                                      - TLS
+                                      - UDP
                                       type: string
                                     targetGroupHealthCheck:
                                       description: HealthCheck is the elb health check
@@ Expand Down @@