✨ add support for the claim.spec.clusterName property #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
schrej
force-pushed
the
feature/claim-clustername-property
branch
from
4347dee to
5e2ca61
Compare
mcbenjemaa
reviewed
Aug 29, 2024
| }, | ||
| )) | ||
| if err != nil { | ||
| if err := r.Client.List(context.Background(), claims, client.MatchingFields{"clusterName": a.GetName()}); err != nil { |
There was a problem hiding this comment.
does this also index the ClusterNameLabel ?
There was a problem hiding this comment.
Yes, it prefers the field but indexes both.
k8s-ci-robot
added
the
needs-rebase
schrej
force-pushed
the
feature/claim-clustername-property
branch
from
5e2ca61 to
5eb8536
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mcbenjemaa, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for the new
spec.clusterNameofIPAddressClaimsthat was introduced with CAPI 1.8. It is respected when checking whether the referenced Cluster is paused. The label is also still supported.I've added an index for claims that gets filled with either the property or the label's value to make it easier to react to cluster unpausing.
Also contains a few dependency upgrades, including CAPI 1.8.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #258