Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add mcbenjemaa to OWNERS_ALIASES #235

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

mcbenjemaa
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2024
@k8s-ci-robot k8s-ci-robot requested review from schrej and srm09 February 20, 2024 13:18
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@mcbenjemaa mcbenjemaa changed the title Add @mcbenjemaa OWNERS_ALIASES 🌱 Add @mcbenjemaa OWNERS_ALIASES Feb 20, 2024
@schrej
Copy link
Member

schrej commented Feb 20, 2024

Thanks for helping maintain this!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcbenjemaa, schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@schrej schrej changed the title 🌱 Add @mcbenjemaa OWNERS_ALIASES 🌱 Add mcbenjemaa OWNERS_ALIASES Feb 20, 2024
@schrej schrej changed the title 🌱 Add mcbenjemaa OWNERS_ALIASES 🌱 Add mcbenjemaa to OWNERS_ALIASES Feb 20, 2024
@schrej
Copy link
Member

schrej commented Feb 20, 2024

@mcbenjemaa please fix the commit message

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Feb 20, 2024
@mcbenjemaa
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mcbenjemaa: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@schrej
Copy link
Member

schrej commented Feb 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4c1bf47 into kubernetes-sigs:main Feb 20, 2024
5 checks passed
@mcbenjemaa mcbenjemaa deleted the patch-2 branch February 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants