-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use envtest binaries from controller-tools repo #255
Conversation
/retest
? |
/retest |
@mboersma Is there some kind of breaking change here/is this a version bump? |
Apparently so, although it was a smooth update for CAPZ. I'll take a look. |
I think the CI failure will be fixed by kubernetes/test-infra#32803. |
/retest |
1 similar comment
/retest |
@Jont828 it's passing now after changing the test-infra job not to pin the kubebuilder envtest version. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates
setup-envtest
to a commit onmain
that fetchesenvtest
binaries from the GitHub release on the controller-tools repo. This is to move away from using GCP resource buckets.Which issue(s) this PR fixes:
Fixes #250
See also: