Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace haproxy with envoy (static configuration) #61

Merged
merged 19 commits into from
May 4, 2024
Merged

replace haproxy with envoy (static configuration) #61

merged 19 commits into from
May 4, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented May 3, 2024

Switching to envoy will give us more features and also the capacity to configure remotely the loadbalancers

Fixes: #58, #57

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2024
@aojea aojea force-pushed the envoy branch 2 times, most recently from f199638 to ee4c9ca Compare May 3, 2024 15:51
danwinship
danwinship reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know much about haproxy or envoy, but...

pkg/loadbalancer/proxy.go Outdated Show resolved Hide resolved
pkg/loadbalancer/proxy.go Outdated Show resolved Hide resolved
pkg/loadbalancer/proxy.go Outdated Show resolved Hide resolved
pkg/loadbalancer/proxy_test.go Show resolved Hide resolved
pkg/loadbalancer/proxy.go Show resolved Hide resolved
pkg/loadbalancer/proxy.go Show resolved Hide resolved
pkg/loadbalancer/proxy.go Outdated Show resolved Hide resolved
pkg/loadbalancer/proxy.go Outdated Show resolved Hide resolved
pkg/loadbalancer/proxy_test.go Show resolved Hide resolved
pkg/loadbalancer/proxy.go Show resolved Hide resolved
@aojea
Copy link
Contributor Author

aojea commented May 3, 2024

Kubernetes e2e suite: [It] [sig-network] LoadBalancers should not have connectivity disruption during rolling update with externalTrafficPolicy=Cluster [Slow]

it is failing in all jobs that means most probably the healtchecker is not working

@aojea
Copy link
Contributor Author

aojea commented May 4, 2024

ok, found the bug, it was on the configuration , envoy has some hot restart mechanism that capture the HUP signal and does not allow to get the new config

Alos tested UDP and it works fine

@aojea aojea changed the title [WIP] replace haproxy with envoy (static configuration) replace haproxy with envoy (static configuration) May 4, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2024
@aojea
Copy link
Contributor Author

aojea commented May 4, 2024

And affinity working too ... added also examples and improve the resilience ... nice experience to learn the envoy APIs , super powerful and expressive though the documentation is super complex

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2024
@aojea
Copy link
Contributor Author

aojea commented May 4, 2024

green, I want to merge to unblock the CI testing, this way we can move on

@aojea aojea merged commit 09eacff into kubernetes-sigs:main May 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Protocol UDP Support
3 participants
@aojea @k8s-ci-robot @danwinship