docker: cross compile binary #173
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| WORKDIR /go/src | ||
| # make deps fetching cacheable | ||
| COPY go.mod go.sum ./ | ||
| RUN go mod download | ||
| # build | ||
| COPY . . | ||
| RUN make build | ||
| ARG TARGETARCH | ||
| RUN GOARCH=$TARGETARCH make build | ||
|
|
||
| # build real cloud-provider-kind image | ||
| FROM docker:25.0-dind |
There was a problem hiding this comment.
will make a seperate PR, but we have no reason to actually ship the daemon right? this image is bigger than we need, we just need the docker CLI, right? or am I missing something.
There was a problem hiding this comment.
we do, the cloud provider kind needs docker when running inside docker
There was a problem hiding this comment.
confirmed we only need the CLI with @aojea
There was a problem hiding this comment.
filed as another PR so we can decide separately #174, but included this existing commit to avoid diff since it's about to merge hopefully
|
/lgtm |
k8s-ci-robot
added
the
lgtm
these jobs are not blocking merge probably we should run just a subset of loadbalancer related tests and require it for merge? |
see discussion in #171, not sure if this is a complete fix but it should help, we avoid qemu entirely