-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up secrets created during the tests. #208
Conversation
Welcome @dargudear-google! |
Hi @dargudear-google. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work locally? could you update the description for your use case?
/ok-to-test |
Yes. I tried with my personal project and secret cleaning was successful with one related error
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dargudear-google, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes/k8s.io#7531 broke Kubernetes CI which reports containing bc478df...445d89e that appears to solely contain this PR I think we need to fix and/or revert. tentatively: it fails because it tries to use the secret manager API even if it's not enabled, leaving the projects stuck in dirty state and causing us to run out of projects. we need to gracefully handle that the project doesn't have the API enabled and therefore has nothing to clean up. |
filed #209 to track next steps. |
we probably should revert the deployment first |
That's done and CI is green again, I did that first before following up here (kubernetes/test-infra#33910), but we will want to get boskos into a state where updating the deployment is safe. |
Here is the PR with API enabled check #211 |
I am working on-recreating a prow job and these prow jobs deleted during migration to community infra. Discussion ref.
I am re-enabling this job to run on community infra.
To run the job in community infra, I need to create secrets from google secret manager.
This PR is to remove secrets created during the job execution.