Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up secrets created during the tests. #208

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

dargudear-google
Copy link
Contributor

@dargudear-google dargudear-google commented Nov 13, 2024

I am working on-recreating a prow job and these prow jobs deleted during migration to community infra. Discussion ref.

I am re-enabling this job to run on community infra.
To run the job in community infra, I need to create secrets from google secret manager.

This PR is to remove secrets created during the job execution.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dargudear-google!

It looks like this is your first PR to kubernetes-sigs/boskos 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/boskos has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2024
Copy link
Contributor

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work locally? could you update the description for your use case?

cmd/janitor/gcp_janitor.py Outdated Show resolved Hide resolved
@krzyzacy
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2024
@dargudear-google
Copy link
Contributor Author

does this work locally? could you update the description for your use case?

Yes. I tried with my personal project and secret cleaning was successful with one related error

Fail to list resource 'topics' from project '<project_id>': ValueError("missing key: creationTimestamp or createTime

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dargudear-google, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 445d89e into kubernetes-sigs:master Nov 19, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 19, 2024
@BenTheElder
Copy link
Member

kubernetes/k8s.io#7531 broke Kubernetes CI which reports containing bc478df...445d89e

that appears to solely contain this PR

I think we need to fix and/or revert.

tentatively: it fails because it tries to use the secret manager API even if it's not enabled, leaving the projects stuck in dirty state and causing us to run out of projects.

we need to gracefully handle that the project doesn't have the API enabled and therefore has nothing to clean up.

@BenTheElder
Copy link
Member

filed #209 to track next steps.

@krzyzacy
Copy link
Contributor

krzyzacy commented Dec 5, 2024

we probably should revert the deployment first

@BenTheElder
Copy link
Member

we probably should revert the deployment first

That's done and CI is green again, I did that first before following up here (kubernetes/test-infra#33910), but we will want to get boskos into a state where updating the deployment is safe.

@dargudear-google
Copy link
Contributor Author

Here is the PR with API enabled check #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants