Generate purls from read sources #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds new support to extract more information from the dpkg database, at the same time it splits the OSs to prepare them to produce purls from the extracted data. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
PackageDBEntry can now output its contents as purl. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Wire purl from OS packages into SPDX packages expressing them. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
While the package type already supported external references, we now support actually writing it into the SBOM. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
When reading go dependencies, we now add a PackageURL external ref to the generated SPDX package. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit modifies the DownloadLocation generated from Go packages. When the package is a module, we will use the proxy.golang.org url to make a zip available. This makes the output of bom equal to ko. When a dependency is not a module, bom will now generate a valid SPDX download locator (eg "git+https://github.com/ ... ) Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit adds support for writing purls in packages describing OCI images. For now, only images stored in registries get a purl, that means that tarred images will not. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
kind/feature
saschagrunert
approved these changes
Mar 8, 2022
|
/retest |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
removed
the
lgtm
|
SOrry @saschagrunert I had forgotten to commit go.mod, its ready now :) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
bom will now annotate system packages, golang dependencies and OCI images (in a registry) with a package URL. Reading this annotation makes it easier to detect what kind of source the spdx package is describing.
Having purls in all artifacts will now allow answering questions like Does this SBOM describe an image?, do we have golang dependency information? what about the system packages in this image?
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Sample run:
/assign @cpanato
/cc @kubernetes-sigs/release-engineering
Does this PR introduce a user-facing change?