-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Parser: Support top-level elements defined with relationships #304
Conversation
SPDX supports defining the top level elementsa of the SBOM using the documentDescribes field and also with relationships. This commit adds support to the parser to detect top level elements specified using the former method. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit improves the license printer in the query package to better recognize when packages have NOASSERTION or NONE in the license field. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
SPDX supports defining the top-level elements of the SBOM using the
documentDescribes
field but also by linking elements to the document with aDESCRIBES
relationship. This commit adds support to the JSON parser to detect top-level elements specified using the former method.I'm also sneaking in a small change to improve printing the licenses in query results.
bom
will now detect better when licenses areNOASSERTION
when choosing which licenses to print.Signed-off-by: Adolfo García Veytia (Puerco) puerco@chainguard.dev
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/assign @cpanato @saschagrunert @xmudrii
/cc @kubernetes-sigs/release-engineering
Does this PR introduce a user-facing change?