-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPDX json definition set to minor version #145
Conversation
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
|
Welcome @lumjjb! |
Hi @lumjjb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
:) |
Thanks Brandon! After the first commit of this file I had wanted to do this change. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lumjjb, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Brandon Lum lumjjb@gmail.com
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
Simplifies the support with the release of newer SPDX versions so a new "patch" version does not need to be defined each time for the JSON struct.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
SPDX struct definitions are tied to minor versions, patch versions are only for documentation updates, so there's no need to specify structs to the level of the patch version :).
Does this PR introduce a user-facing change?
No, unless there are uses of the
spdx/json
pkg