New spdx+json parser! #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit implements the first iteration of an SPDX+JSON parser in bom. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
kind/feature
This commit adds two json sboms to use in test cases Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit adds two unit tests to check the SPDX+JSON parser Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements a full json parser matching our SPDX 2.2.2 type. The
spdx.OpenDocnow includes a simple logic to detect which kind of SBOM we are reading and call the appropriate parsing function.Unit tests for the new parser are included as well as two sample JSON SBOMs to check the parser integrity.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Our json type is missing a few fields, I will implement those into the type (and parser) in a follow-up
/cc @jeremyrickard
Does this PR introduce a user-facing change?