Enable Prometheus metrics without ServiceMonitor

[prashcr]

Is your feature request related to a problem?
I want to enable Prometheus metrics on aws-load-balancer-controller without creating a ServiceMonitor and having Prometheus Operator on my Kubernetes cluster. This is because I'm using an alternative Prometheus collector: Grafana Agent.

Currently the Helm chart defines a single serviceMonitor.enabled variable to enable both the Prometheus metrics service and the ServiceMonitor.

Describe the solution you'd like
The Helm charts defines a new metrics.enabled variable. The metrics Service is created if metrics.enabled OR serviceMonitor.enabled

Related
aws/eks-charts#959

[oliviassss]

@prashcr, thanks for bringing this up, feel free to raise a PR.

[prashcr]

@oliviassss Thanks, here it is: #3245

[darren-recentive]

@oliviassss @orsenthil @jerryhe1999
Anything I can do to help in finishing up this Issue / PR? 😄

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Helinanu]

Is the pending PR still valid? Would really like this feature since we cannot use prometheus operator

[qoehliang]

Would be awesome if we could get the PR merged. Our use case is we use Argo CD sync-waves to deploy several open-source applications in a particular sequence. We currently use the kube-prometheus-stack and aws-load-balancer-controller, and it creates a circular dependency when using sync-waves. E.G. kube-prometheus-stack can't become healthy until the Ingress is healthy, which is dependent on the aws-load-balancer-controller being up and available. However, if we attempt to place aws-load-balancer-controller first in priority using a faster sync wave, it will fail to sync if we enable ServiceMonitors as the CRD hasn't been deployed by the kube-prometheus-stack yet.

If we disable ServiceMonitors for aws-load-balancer-controller to unblock this issue and create the ServiceMonitor via a separate application, we also lose the creation of the Service which is not ideal. Hence, this PR would fix the issue and allow us to use metrics.enabled flag to enable creation of the Service but not the ServiceMonitor, so that we can sequence the aws-load-balancer-controller to sync first, so that the kube-prometheus-stack can then sync afterwards and the Ingress resource can become healthy.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Andrea-Gallicchio]

Can we reopen this issue please?