Check ARN for user ID strict check #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Update go version in: #661 |
wongma7
reviewed
Dec 7, 2023
|
/retest |
micahhausler
reviewed
Dec 7, 2023
nckturner
force-pushed
the
check-arn-for-useridstrict
branch
2 times, most recently
from
8388d98
to
1203a89
Compare
|
e2e tests passed: Will look into failure but its not blocking. |
micahhausler
reviewed
Dec 7, 2023
nckturner
force-pushed
the
check-arn-for-useridstrict
branch
from
1203a89
to
6dd1340
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micahhausler, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nckturner
added a commit
to nckturner/aws-iam-authenticator
that referenced
this pull request
Dec 7, 2023
nckturner
added a commit
to nckturner/aws-iam-authenticator
that referenced
this pull request
Dec 7, 2023
nckturner
added a commit
to nckturner/aws-iam-authenticator
that referenced
this pull request
Dec 7, 2023
nckturner
added a commit
to nckturner/aws-iam-authenticator
that referenced
this pull request
Dec 7, 2023
nckturner
added a commit
that referenced
this pull request
Dec 7, 2023
nckturner
added a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Check ARN when mapping based on User ID. This is necessary because IAM User names/ARNs can change, and without this check, it would be difficult to determine which IAM users currently have access to a cluster.