Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths to dynamic_provisioning_s3 manifests #119

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Fix paths to dynamic_provisioning_s3 manifests #119

merged 1 commit into from
Dec 25, 2019

Conversation

nathanweeks
Copy link
Contributor

Is this a bug fix or adding new feature?
Bug fix

What is this PR about? / Why do we need it?
In the dynamic_provisioning_s3 example, the code block that creates the StorageClass, PVC, and Pod uses pathnames for the dynamic_provisioning manifests, rather than the dynamic_provisioning_s3 example.

What testing is done?
Executed the updated commands while deploying/testing the AWS CSI FSx for Lustre driver in my EKS cluster.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @nathanweeks!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nathanweeks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2019
@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2019
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs/claim.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs/pod.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning_s3/specs/storageclass.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs_s3/claim.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

Suggested change
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs_s3/claim.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning_s3/specs/claim.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the path here to be kubectl apply -f examples/kubernetes/dynamic_provisioning_s3/specs/claim.yaml ? then the PR is good to merge.

>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs/pod.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning_s3/specs/storageclass.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs_s3/claim.yaml
>> kubectl apply -f examples/kubernetes/dynamic_provisioning/specs_s3/pod.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@leakingtapan
Copy link
Contributor

leakingtapan commented Dec 9, 2019

@nathanweeks thx for the fix. You will need to sign CLA for the PR to be merged 😃

@nathanweeks
Copy link
Contributor Author

@leakingtapan I need to check with administration to verify that this can be considered an individual contribution. I should hopefully find out soon.

@leakingtapan
Copy link
Contributor

leakingtapan commented Dec 19, 2019

@nathanweeks just checkin, got any luck to check with administration and address the comment?

@nathanweeks
Copy link
Contributor Author

@leakingtapan : yes, and thanks for the reminder! I signed an individual CLA, updated the email associated with the commit, and force pushed to the dynamic-provisioning-s3 branch.

@leakingtapan
Copy link
Contributor

Seems CLA check is still failed. Could you also address the comment? thx :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 22, 2019
@nathanweeks
Copy link
Contributor Author

@leakingtapan : I finally figured it out. Sorry it took so long!

@leakingtapan
Copy link
Contributor

Could you address my comment for your change? After that this PR is good to merge :)

@nathanweeks
Copy link
Contributor Author

Done. Apologies for making a hassle the simplest of PRs!

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, nathanweeks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit f85b53c into kubernetes-sigs:master Dec 25, 2019
@Jeffwan Jeffwan mentioned this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants