Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to provision StorageClasses #298

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Jan 10, 2021

Is this a bug fix or adding new feature?
New feature in the helm chart

What is this PR about? / Why do we need it?
Most application charts don't usually create StorageClasses. They create PVCs. This is extending the work done in #274. The chart itself is kind of broken unless image.tag is set to "master". #291 will probably address that.

What testing is done?
Installed the chart with the following custom values:

image:
  tag: "master"

serviceAccount:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::<accountId>:role/<roleName>

storageClasses:
- name: efs-sc
  mountOptions:
  - tls
  parameters:
    provisioningMode: efs-ap
    fileSystemId: fs-<id>
    directoryPerms: "700"

Then tried creating a PVC and a pod that used it:

---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: efs-claim
spec:
  accessModes:
    - ReadWriteMany
  storageClassName: efs-sc
  resources:
    requests:
      storage: 5Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: efs-app
spec:
  containers:
    - name: app
      image: centos
      command: ["/bin/sh"]
      args: ["-c", "while true; do echo $(date -u) >> /data/out; sleep 5; done"]
      volumeMounts:
        - name: persistent-storage
          mountPath: /data
  volumes:
    - name: persistent-storage
      persistentVolumeClaim:
        claimName: efs-claim

Verified the following:

  • PV was provisioned.
  • EFS access point was created.
  • test pod was writing to EFS as expected.

@k8s-ci-robot
Copy link
Contributor

Hi @gazal-k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2021
@gazal-k gazal-k changed the title feat: Add option to provision StorageClasses feat: Add option to provision StorageClasses Jan 10, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2021
@ayberk
Copy link

ayberk commented Jan 15, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2021
@ayberk
Copy link

ayberk commented Jan 15, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@gazal-k
Copy link
Contributor Author

gazal-k commented Jan 15, 2021

@gazal-k: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-aws-efs-csi-driver-e2e 4723e9f link /test pull-aws-efs-csi-driver-e2e
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

The test failures in here don't really seem to be related to this change.

@ayberk
Copy link

ayberk commented Jan 30, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2021
Most application charts don't usually create `StorageClass`es. They create PVCs. This is extending the work done in kubernetes-sigs#274. The chart itself is kind of broken unless `image.tag` is set to "master". kubernetes-sigs#291 will probably address that.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 8, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 10, 2021

/lgtm

fyi @kbasv I'm dropping an lgtm but please review as well

@wongma7
Copy link
Contributor

wongma7 commented Mar 10, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, gazal-k, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@kbasv
Copy link

kbasv commented Mar 10, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kbasv: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit aa7cd84 into kubernetes-sigs:master Mar 11, 2021
@gazal-k gazal-k deleted the sc branch March 11, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants