-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added helm repo yaml in docs folder #194
Conversation
This will allow helm to add the public docs of this git repo as a helm repo. The helm tar packages are actually stored in git releases still.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @kferrone! |
Hi @kferrone. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will allow helm to add the public docs of this git repo as a helm repo. The helm tar packages are actually stored in git releases still.
I signed it |
/ok-to-test |
Thx for creating the helm index! I will move the file to github page in a separate branch and make it public once this is merged. |
Just created gh-pages branch, please create the index in that branch at project root and update the helm install section in README |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kferrone, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just curious, what's the benefit of using a separate branch vs keeping it at master? |
This will allow helm to add the public docs of this git repo as a helm
repo. The helm tar packages are actually stored in git releases still.
Is this a bug fix or adding new feature?
A new feature as this repo did not have a public helm repo and required installing the charts tar.gz directly.
What is this PR about? / Why do we need it?
Not all ways of using helm will allow you to install a chart from a url. Installing charts from a repo always works. For example if you are using FluxCD Helm Operator or AWS CDK, they do not support installing from url directly without a specific repo. . . as far as I know.
What testing is done?
I have done this before. I can't directly test this repo until the docs folder is made public.
As long as the docs folder is public on Github Pages then the following command would work:
I made this exact repo available on my account to test out.
Add the repo
Search the repo:
which should display:
Now try a pull and see the download:
Fixes: #146