Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty StorageClasses to static example #850

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Apr 23, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? fix from kubernetes-sigs/aws-efs-csi-driver#423 . without this change, pvc may bind to default storageclass pv which is NOT intended!

What testing is done?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Apr 23, 2021

/retest

@ayberk
Copy link
Contributor

ayberk commented Apr 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@AndyXiangLi
Copy link
Contributor

/test pull-aws-ebs-csi-driver-external-test-latest

@wongma7 wongma7 closed this Apr 26, 2021
@wongma7 wongma7 reopened this Apr 26, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1896

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.8%) to 79.253%

Totals Coverage Status
Change from base Build 1879: -8.8%
Covered Lines: 1952
Relevant Lines: 2463

💛 - Coveralls

@wongma7 wongma7 merged commit 95ab71a into kubernetes-sigs:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants