Document behavior wrt minimum and maximum iops #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 1257
💛 - Coveralls |
ayberk
approved these changes
Oct 7, 2020
docs/README.md
Outdated
| @@ -33,7 +33,7 @@ There are several optional parameters that could be passed into `CreateVolumeReq | |||
| |-----------------------------|-----------------------------------|----------|---------------------| | |||
| | "csi.storage.k8s.io/fsType" | xfs, ext2, ext3, ext4 | ext4 | File system type that will be formatted during volume creation | | |||
| | "type" | io1, io2, gp2, sc1, st1,standard | gp2 | EBS volume type | | |||
| | "iopsPerGB" | | | I/O operations per second per GiB. Required when io1 or io2 volume type is specified | | |||
| | "iopsPerGB" | | | I/O operations per second per GiB. Required when io1 or io2 volume type is specified. If this value multiplied by the size of a requested volume produces a value below the minimum or above the maximum IOPs allowed for the volume type, AWS will return an error and volume creation will fail | | |||
There was a problem hiding this comment.
We should probably add a link to the limits: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html
Funnily enough I don't see the minimum IOPS on the chart.
There was a problem hiding this comment.
added a link.
Yeah it's buried below "io1 and io2 volumes can range in size from 4 GiB to 16 TiB. You can provision from 100 IOPS ..."
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? unlike in-tree, we error if the iops of a volume is below min or above max. Document it to avoid surprises like #575
What testing is done? N/A