Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overlay for ECR images #570

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add overlay for ECR images #570

merged 1 commit into from
Oct 1, 2020

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Sep 30, 2020

Is this a bug fix or adding new feature?
N/A

What is this PR about? / Why do we need it?
Adds a new kustomization layout that uses the images from ECR instead of quay and docker hub. Fixes #554.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ayberk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 30, 2020
@ayberk
Copy link
Contributor Author

ayberk commented Sep 30, 2020

/assign wongma7

@coveralls
Copy link

coveralls commented Sep 30, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.27%
Totals Coverage Status
Change from base Build 1225: 0.0%
Covered Lines: 1489
Relevant Lines: 1855
💛 - Coveralls

wongma7
wongma7 reviewed Sep 30, 2020
View reviewed changes
deploy/kubernetes/overlays/stable/ecr/kustomization.yaml
newName: 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/csi-attacher
newTag: v1.2.0
- name: quay.io/k8scsi/livenessprobe
newName: 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/csi-liveness-probe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for v2.0.0, I changed the name to just eks/livenessprobe to match the quay name. not applicable here, just noting for future when it gets bumped to v2.0.0.....

@wongma7
Copy link
Contributor

wongma7 commented Sep 30, 2020

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@wongma7
Copy link
Contributor

wongma7 commented Sep 30, 2020

does having nested kustomize work? stable and stable/ecr.

@wongma7
Copy link
Contributor

wongma7 commented Oct 1, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

1 similar comment
@ayberk
Copy link
Contributor Author

ayberk commented Oct 1, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@k8s-ci-robot k8s-ci-robot merged commit 6e470fe into kubernetes-sigs:master Oct 1, 2020
@ayberk ayberk deleted the ecr_images branch October 1, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container images are hosted on docker hub
4 participants
@ayberk @k8s-ci-robot @coveralls @wongma7