-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeAffinity to avoid Fargate worker nodes #488
Conversation
Add nodeAffinity in the daemonset to avoid schedule ebs-csi-node pods on Fargate worker nodes, as Fargate does not support ebs
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @bgsilvait! |
Hi @bgsilvait. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1082
💛 - Coveralls |
/assign @wongma7 |
I signed it |
/lgtm This is the same way we avoid scheduling kube-proxy there |
/ok-to-test |
@wongma7 I see these 2 e2e tests failed: [ebs-csi-e2e] [single-az] Dynamic Provisioning should create a volume on demand with volume type "sc1" and fs type "ext2" and [ebs-csi-e2e] [single-az] Snapshot should create a pod, write and read to it, take a volume snapshot, and create another pod from the snapshot I don't see how my PR with nodeAffinity can cause that errors. Yes is the same way used to avoid scheduling kube-proxy on Fargate |
/test pull-aws-ebs-csi-driver-e2e-single-az |
/retest |
/test pull-aws-ebs-csi-driver-e2e-single-az |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the helm char as well here.
add nodeAffinity rule to avoid pods on AWS Fargate.
@leakingtapan Ok, helm chart fixed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgsilvait, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
Add nodeAffinity in the daemonset to avoid schedule ebs-csi-node pods on Fargate worker nodes, as Fargate does not support ebs.
If there is a pod running in Fargate, the daemoset tries to place ebs-csi-node pod in the same node, with causes the pod to Pending state.
What testing is done?
Apply the original with kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master" -> pods Pending.
Adding the nodeAffinity, all pods in the Pending state on Fargate are deleted and new are only created at EC2 nodes