Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to golang 1.12 #329

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Upgrade to golang 1.12 #329

merged 1 commit into from
Aug 7, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes: #242

/cc @wongma7

@k8s-ci-robot k8s-ci-robot requested a review from wongma7 August 6, 2019 22:58
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2019
@leakingtapan
Copy link
Contributor Author

/cc @gyuho

@k8s-ci-robot k8s-ci-robot requested a review from gyuho August 6, 2019 22:59
@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.308%
Totals Coverage Status
Change from base Build 723: 0.0%
Covered Lines: 1178
Relevant Lines: 1652
💛 - Coveralls

@gyuho
Copy link
Member

gyuho commented Aug 6, 2019

@leakingtapan Let me release a new binary with 1.12.7.

@gyuho
Copy link
Member

gyuho commented Aug 6, 2019

Released https://github.com/aws/aws-k8s-tester/releases/tag/0.3.0.

@leakingtapan leakingtapan force-pushed the golang112 branch 2 times, most recently from 902ed32 to 348e1f7 Compare August 7, 2019 03:14
@gyuho
Copy link
Member

gyuho commented Aug 7, 2019

Had to bump up hard coded Go version aws/aws-k8s-tester@3b052ed

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit f23d7d7 into kubernetes-sigs:master Aug 7, 2019
@leakingtapan leakingtapan deleted the golang112 branch August 7, 2019 21:55
@wongma7 wongma7 mentioned this pull request Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 Awaiting requested review from wongma7

@gyuho gyuho Awaiting requested review from gyuho

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Golang 1.12
4 participants
@leakingtapan @k8s-ci-robot @coveralls @gyuho