Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm chart #303

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Add helm chart #303

merged 1 commit into from
Jun 6, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes: #99

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
@leakingtapan
Copy link
Contributor Author

/cc @bertinatto

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 654

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.523%
Totals Coverage Status
Change from base Build 653: 0.0%
Covered Lines: 1085
Relevant Lines: 1517
💛 - Coveralls

bertinatto
bertinatto reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with helm, so I can't reliably evaluate these additions.

Going forward, is there a way to unify both manifest files (the template added in this PR and the one in the deploy dir)?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 11fddf5 into kubernetes-sigs:master Jun 6, 2019
@leakingtapan leakingtapan deleted the helm branch June 6, 2019 16:38
@leakingtapan leakingtapan mentioned this pull request Jun 6, 2019
Closed
@leakingtapan
Copy link
Contributor Author

@bertinatto good point, I don't have a good answer for this as well. created a new issue to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Helm chart for driver
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto