-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Pull Request Template #2208
Upgrade Pull Request Template #2208
Conversation
Code Coverage DiffThis PR does not change the code coverage |
Note creating release-notes becomes as easy as running:
Can also show which dependencies changed by toggling --dependencies=true for those worried about CVEs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElijahQuinones The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Flake |
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
Add release-note to pull request template so that we can think about release-notes at PR time and use Kubernetes release-notes generator instead of hand-crafting release notes at the end of each release.
Also switches first question to suggesting to add a GitHub label. Hopefully one-day we can add an
area/helm
label as well.Impact: Saves ~25 minutes crafting release notes (if you aren't using OSS-Repo-Management-Tools/get_pull_requests_since_last_version), and a team check-in about what note goes where.
How was this change tested?
N/A
Does this PR introduce a user-facing change?