Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume/snapshot tagging and FSR e2e tests #1847

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add volume/snapshot tagging and FSR e2e tests #1847

merged 2 commits into from
Dec 8, 2023

Conversation

ConnorJC3
Copy link
Contributor

Is this a bug fix or adding new feature?

New feature for e2e tests

What is this PR about? / Why do we need it?

This PR is split into 3 commits:

  • Fix controller.CreateSnapshot to create new err variable instead of overwriting existing with nil
    Fixes a minor logging bug discovered during the e2e test development
  • Add e2e snapshot tests
    Adds tests for creating a volume and snapshot with additional tags
  • Add e2e FSR tests
    Adds tests for creating a snapshot with an FSR zone

What testing is done?

This PR is adding new tests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 29, 2023
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko
AndrewSirenko requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for all the added test-coverage gained by integrating EC2 API into our e2e tests. I might integrate EC2 API into ModifyVolume e2e tests now too.

Here are a few comments after my first look, might have a few more comments after we merge the refactoring PR that this is stacked on top of.

tests/e2e/requires_aws_api.go Show resolved Hide resolved
tests/e2e/requires_aws_api.go Outdated Show resolved Hide resolved
tests/e2e/requires_aws_api.go Outdated Show resolved Hide resolved
tests/e2e/requires_aws_api.go Outdated
},
ClaimSize: driver.MinimumSizeForVolumeType(awscloud.VolumeTypeGP3),
VolumeMount: testsuites.VolumeMountDetails{
NameGenerate: "test-volume-",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rely on DefaultVolumeName and DefaultMountPath for these test's VolumeMount's? (Or create a VolumeMount const in e2e_utils shared across each test-case?)

(To not have hanging constants. Yes, the old dynamic provisioning tests would need to be refactored to use these as well, but I think that's a PR worth making.)

Copy link
Contributor Author

@ConnorJC3 ConnorJC3 Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't using those defaults is reasonable because this is a generator so those values don't make sense. I created a DefaultGeneratedVolumeMount var (cannot be const, as its a struct) instead.

tests/e2e/requires_aws_api.go Outdated Show resolved Hide resolved
tests/e2e/requires_aws_api.go Outdated Show resolved Hide resolved
tests/e2e/requires_aws_api.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2023
@AndrewSirenko AndrewSirenko mentioned this pull request Dec 4, 2023
Merged
@ConnorJC3
Fix controller.CreateSnapshot to create new err variable instead of o…
3e4c2cf 
…verwriting existing with nil

Signed-off-by: Connor Catlett <conncatl@amazon.com>
@ConnorJC3
Add e2e snapshot and FSR tests
46a2f03
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 7, 2023
torredil
torredil approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2023
@ConnorJC3
Copy link
Contributor Author

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2023
@ConnorJC3
Copy link
Contributor Author

/retest

torredil
torredil reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrewSirenko
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit b894ce5 into kubernetes-sigs:master Dec 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @k8s-ci-robot @AndrewSirenko @torredil