Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext2 tests #1841

Closed
wants to merge 1 commit into from
Closed

ext2 tests #1841

wants to merge 1 commit into from

Conversation

torredil
Copy link
Member

Do not merge this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from torredil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2023
@torredil torredil changed the title ext3 tests ext2 tests Nov 17, 2023
Copy link

Code Coverage Diff

This PR does not change the code coverage

Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil
Copy link
Member Author

External Storage suite does not test EXT2. Additionally,mount-utils does not support resizing EXT2 filesystems. Mounting EXT2 might be unintentionally supported.

Reverted back to the old non-minimal base image and was able to successfully mount a volume referencing the following StorageClass:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
parameters:
  csi.storage.k8s.io/fstype: ext2

Driver node pod logs:

I1117 19:20:12.823190       1 mount_linux.go:515] Disk "/dev/nvme1n1" appears to be unformatted, attempting to format as type: "ext2" with options: [/dev/nvme1n1]
I1117 19:20:13.009321       1 mount_linux.go:526] Disk successfully formatted (mkfs): ext2 - /dev/nvme1n1 /var/lib/kubelet/plugins/kubernetes.io/csi/ebs.csi.aws.com/a1c54e5ed5be5937557d56b07effbb1a8004afb6927733def3f85b8cb933c94f/globalmount
I1117 19:20:13.011054       1 mount_linux.go:253] Cannot run systemd-run, assuming non-systemd OS
E1117 19:20:13.044698       1 resizefs_linux.go:149] Not able to parse given filesystem info. fsType: ext2, will not resize
E1117 19:20:13.044946       1 driver.go:125] "GRPC error" err="rpc error: code = Internal desc = Could not determine if volume \"vol-0db1391077f6aded1\" (\"/dev/nvme1n1\") need to be resized:  Could not parse fs info on given filesystem format: ext2. Supported fs types are: xfs, ext3, ext4"

Notice the resize error logged.


There are tests for EXT3: ✅

  • [Testpattern: Dynamic PV (ext3)] volumes should allow exec of files on the volume
  • [Testpattern: Dynamic PV (ext3)] volumes should store data

/close

@k8s-ci-robot
Copy link
Contributor

@torredil: Closed this PR.

In response to this:

External Storage suite does not test EXT2. Additionally,mount-utils does not support resizing EXT2 filesystems. Mounting EXT2 might be unintentionally supported.

Reverted back to the old non-minimal base image and was able to successfully mount a volume referencing the following StorageClass:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
 name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
parameters:
 csi.storage.k8s.io/fstype: ext2

Driver node pod logs:

I1117 19:20:12.823190       1 mount_linux.go:515] Disk "/dev/nvme1n1" appears to be unformatted, attempting to format as type: "ext2" with options: [/dev/nvme1n1]
I1117 19:20:13.009321       1 mount_linux.go:526] Disk successfully formatted (mkfs): ext2 - /dev/nvme1n1 /var/lib/kubelet/plugins/kubernetes.io/csi/ebs.csi.aws.com/a1c54e5ed5be5937557d56b07effbb1a8004afb6927733def3f85b8cb933c94f/globalmount
I1117 19:20:13.011054       1 mount_linux.go:253] Cannot run systemd-run, assuming non-systemd OS
E1117 19:20:13.044698       1 resizefs_linux.go:149] Not able to parse given filesystem info. fsType: ext2, will not resize
E1117 19:20:13.044946       1 driver.go:125] "GRPC error" err="rpc error: code = Internal desc = Could not determine if volume \"vol-0db1391077f6aded1\" (\"/dev/nvme1n1\") need to be resized:  Could not parse fs info on given filesystem format: ext2. Supported fs types are: xfs, ext3, ext4"

Notice the resize error logged.


There are tests for EXT3: ✅

  • [Testpattern: Dynamic PV (ext3)] volumes should allow exec of files on the volume
  • [Testpattern: Dynamic PV (ext3)] volumes should store data

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants