Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade driver & sidecar dependencies for v1.25.0 #1835

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Upgrade driver & sidecar dependencies for v1.25.0 #1835

merged 1 commit into from
Nov 10, 2023

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
Release

What is this PR about? / Why do we need it?
Upgrading dependencies ahead of v1.25.0 of aws-ebs-csi-driver. (And small govet-suggested fix in node.go from klog version bump)

What testing is done?
make test make verify

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
@torredil
Copy link
Member

torredil commented Nov 9, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2023
@AndrewSirenko
Copy link
Contributor Author

/un-hold

@AndrewSirenko
Copy link
Contributor Author

/retest

ConnorJC3
ConnorJC3 requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some sort of re-formatting applied to values.yaml that is removing a lot of lines by your editor or something? Please undo.

charts/aws-ebs-csi-driver/values.yaml Outdated Show resolved Hide resolved
charts/aws-ebs-csi-driver/values.yaml Outdated Show resolved Hide resolved
charts/aws-ebs-csi-driver/values.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2023
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
torredil
torredil approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@AndrewSirenko
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 130cb81 into kubernetes-sigs:master Nov 10, 2023
8 checks passed
@AndrewSirenko AndrewSirenko deleted the 1.25DepUpgrade branch December 5, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 requested changes

@torredil torredil torredil approved these changes

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewSirenko @torredil @ConnorJC3 @k8s-ci-robot