Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: node-driver-registrar sidecar fixes #1815

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Chart: node-driver-registrar sidecar fixes #1815

merged 2 commits into from
Nov 2, 2023

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Oct 27, 2023

Is this a bug fix or adding new feature?
bug fix and new feature
What is this PR about? / Why do we need it?

What testing is done?
helm template . -f values.yaml

  • additionalArgs now properly renders when provided
  • Default livenessProbe is unchanged

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jukie!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jukie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@AndrewSirenko
Copy link
Contributor

/ok-to-test

Thanks for catching this and contributing @jukie!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2023
@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023

/retest-required

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023

/retest-required

@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023

/test pull-aws-ebs-csi-driver-test-helm-chart

@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023

Thanks @AndrewSirenko, should be ready now.

torredil
torredil approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @jukie /lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023

/assign wongma7

@ConnorJC3
Copy link
Contributor

I'm going to hold off on officially approving until the PRs for the ongoing 1.23.2/1.24.1 releases are done, but consider this psuedo-approval.

@jukie
Copy link
Contributor Author

jukie commented Oct 27, 2023 •
edited
Loading

Okay, does that mean this wouldn't be released until 1.24.2?

@ConnorJC3
Copy link
Contributor

Okay, does that mean this wouldn't be released until 1.24.2?

We're releasing 1.23.2/1.24.1 to fix two specific high severity issues - all other fixes/features/etc (like this PR) will go in the next monthly release, 1.25.0 in this case.

1.24.0 was about 2 weeks ago, so 1.25.0 will go out in roughly 2 weeks.

@jukie
Copy link
Contributor Author

jukie commented Oct 30, 2023

Great, thanks!

@ConnorJC3 ConnorJC3 force-pushed the master branch 2 times, most recently from 24a8e7b to bddbe0b Compare November 1, 2023 18:08
@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@jukie
Copy link
Contributor Author

jukie commented Nov 2, 2023 •
edited
Loading

@ConnorJC3 is that a new check? And would that be a blocker here since this only touches the manifests?
Edit: rebase was all that I needed, please re-review when you have time

@jukie jukie force-pushed the fix-node-driver-registrar-args branch from 099366c to 73cac31 Compare November 2, 2023 17:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@ConnorJC3
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 2, 2023
@jukie jukie requested a review from torredil November 2, 2023 18:18
@jukie
Copy link
Contributor Author

jukie commented Nov 2, 2023

@torredil could you add another lgtm after my rebase to fix the go vuln check?

@torredil
Copy link
Member

torredil commented Nov 2, 2023

@jukie Absolutely! thanks again for your contribution, we highly appreciate it -- great work here. /lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3dde68b into kubernetes-sigs:master Nov 2, 2023
8 checks passed
@jukie jukie deleted the fix-node-driver-registrar-args branch November 2, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@AndrewSirenko AndrewSirenko Awaiting requested review from AndrewSirenko

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@wongma7 wongma7

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
6 participants
@jukie @k8s-ci-robot @AndrewSirenko @ConnorJC3 @torredil @wongma7