Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update driver manifest files #181

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Update driver manifest files #181

merged 1 commit into from
Jan 21, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Jan 20, 2019 •
edited
Loading

Is this a bug fix or adding new feature?
/bug

What is this PR about? / Why do we need it?

  1. rename controller daemon set name and node stateful set name. This
    resolves name collision when deploying multiple CSI drivers.
  2. remove secrets from node ebs-plugin since it is not needed
  3. update sample manifest files with better names

What testing is done?
e2e test passed

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2019
@leakingtapan
Copy link
Contributor Author

@dkoshkin

@coveralls
Copy link

coveralls commented Jan 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.931%
Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 602
Relevant Lines: 1182
💛 - Coveralls

dkoshkin
dkoshkin reviewed Jan 20, 2019
View reviewed changes
deploy/kubernetes/controller.yaml Show resolved Hide resolved
deploy/kubernetes/node.yaml Outdated Show resolved Hide resolved
Update driver manifest files
a3afb0e 
1) rename controller daemon set name and node stateful set name. This
resolves name collision when deploying multiple csi driver.
2) remove secret from node ebs-plugin since it is not needed
3) update sample manifest files with better names
@leakingtapan leakingtapan merged commit f55629c into kubernetes-sigs:master Jan 21, 2019
@leakingtapan leakingtapan deleted the manifest branch January 21, 2019 18:05
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request Apr 13, 2021
@openshift-merge-robot
Merge pull request kubernetes-sigs#181 from jsafrane/owners-bz
642156e 
Add BZ component to OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin dkoshkin left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @coveralls @dkoshkin