Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart #168

Closed
wants to merge 15 commits into from
Closed

Conversation

shanesiebken
Copy link

Is this a bug fix or adding new feature?
New Feature.

Initial Helm Chart for driver components.

What is this PR about? / Why do we need it?
Starting point for work on #99

What testing is done?
Deployed in staging cluster and confirmed output. More testing should be added.

More work should likely be done on this - but it captures a good portion of the "default" configuration of the driver components, as well as some of the more advanced functionality found in other charts - affinity, selectors, etc.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanesiebken
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: d-nishi

If they are not already assigned, you can assign the PR to them by writing /assign @d-nishi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @shanesiebken. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 3, 2019
@shanesiebken shanesiebken changed the title initial chart commit Helm Chart Jan 3, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 296

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 296

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2019
@shanesiebken
Copy link
Author

Trying to get my CLA sorted out - sorry for the delay. I'm not getting the email after following the auth flow for some reason.

@leakingtapan
Copy link
Contributor

@shanesiebken Thanks for the contribution! Just a note, you will need to sign CLA to get the code merged

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

@shanesiebken: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-aws-ebs-disk-csi-driver-verify 2f7fa2f link /test pull-aws-ebs-disk-csi-driver-verify
pull-aws-ebs-csi-driver-sanity 2f7fa2f link /test pull-aws-ebs-csi-driver-sanity
pull-aws-ebs-csi-driver-integration 2f7fa2f link /test pull-aws-ebs-csi-driver-integration
pull-aws-ebs-csi-driver-unit 2f7fa2f link /test pull-aws-ebs-csi-driver-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants