-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart #168
Helm Chart #168
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanesiebken If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @shanesiebken. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1cd72bd
to
becb687
Compare
1 similar comment
/ok-to-test |
Trying to get my CLA sorted out - sorry for the delay. I'm not getting the email after following the auth flow for some reason. |
@shanesiebken Thanks for the contribution! Just a note, you will need to sign CLA to get the code merged |
becb687
to
2f7fa2f
Compare
@shanesiebken: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Is this a bug fix or adding new feature?
New Feature.
Initial Helm Chart for driver components.
What is this PR about? / Why do we need it?
Starting point for work on #99
What testing is done?
Deployed in staging cluster and confirmed output. More testing should be added.
More work should likely be done on this - but it captures a good portion of the "default" configuration of the driver components, as well as some of the more advanced functionality found in other charts - affinity, selectors, etc.