Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Fix csi-resizer tag and bump to v1.1.0 #1085

Merged

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Oct 9, 2021

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Follow up on #1080. I tried to keep versions consistent between GCR and ECR, but did not notice 1.0.1 was not built against Kubernetes 1.18.3.

This uses v1.1.0-eks-1-18-3, so all ECR images are built against Kubernetes 1.18.3, and updates the GCR image as to v1.1.0 as well for consistency.

Changelog: https://github.com/kubernetes-csi/external-resizer/blob/release-1.1/CHANGELOG-1.1.md

What testing is done?

docker pull public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.1.0-eks-1-18-3
docker pull k8s.gcr.io/sig-storage/csi-resizer:v1.1.0

Running the ECR image in multiple environments (actually v1.1.0-eks-1-19-8 to be exact).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @maxbrunet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2021
@wongma7
Copy link
Contributor

wongma7 commented Oct 11, 2021

/ok-to-test
/lgtm
/approve
Thanks. also double checked the pull from my end, didn't catch the tagging difference either first time around, I understand the reasoning to minimize change.

$ docker pull public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.1.0-eks-1-18-3
v1.1.0-eks-1-18-3: Pulling from eks-distro/kubernetes-csi/external-resizer
9da98c321efd: Pull complete
0fdf822eba02: Pull complete
195f0d05bac8: Pull complete
346c1495c1be: Pull complete
31b54dcdbe20: Pull complete
Digest: sha256:a01476f47906c07b7fc10d061043de0554cbf74eba3a06e72ff03c8f826f9e31
Status: Downloaded newer image for public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.1.0-eks-1-18-3
public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.1.0-eks-1-18-3

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxbrunet, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 085e5e2 into kubernetes-sigs:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants