Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build IsCorruptedMnt not implemented #1047

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Sep 8, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? as seen in our master branch CI https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/3508198636 the windows build fails.

this was not cauhgt by PR CI because no PR CI exercises the windows build, I've assigned myself a task to fix this: #1046

After this merges, what I plan to do is retag 1.1.4 and 1.2.1 to trigger another image rebuild. It is not pretty but, since no images for 1.1.4 or 1.2.1 got pushed to docker hub/gcr there is no harm.

edit: 1.1.4 and 1.2.1 failed for a different reason than master branch, they timed out unexpectedly after 1hr: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/aws-ebs-csi-driver-push-images/1433833154082246656
the 1.1.3 build succeeded after 45 mins: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/aws-ebs-csi-driver-push-images/1418730174391783424

What testing is done?
$ make windows/amd64
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -mod=vendor -ldflags "-X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.driverVersion=v1.2.0 -X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud.driverVersion=v1.2.0 -X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.gitCommit=3b6a45aace77298ad774fba267096aa7d0d3a3c8 -X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.buildDate=2021-09-08T20:27:35+00:00 -s -w" -o bin/aws-ebs-csi-driver.exe ./cmd/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2021
@vdhanan
Copy link
Contributor

vdhanan commented Sep 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit c428c04 into kubernetes-sigs:master Sep 8, 2021
k8s-ci-robot added a commit that referenced this pull request Sep 16, 2021
…047-origin-release-1.2

[release-1.2] Automated cherry pick of #1047: Fix windows build IsCorruptedMnt not implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants