Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes e2e tests of the driver #470

Closed
jsafrane opened this issue Mar 23, 2020 · 9 comments · Fixed by #726
Closed

Add Kubernetes e2e tests of the driver #470

jsafrane opened this issue Mar 23, 2020 · 9 comments · Fixed by #726
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@jsafrane
Copy link
Contributor

Kubernetes allows to run its e2e tests against a CSI driver: https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/external

It will go through all Kubernetes features - dynamic provisioning, topology, subpath, volume expansion, snapshots, cloning... It allows a CSI driver to select features to tests (e.g. no cloning for AWS EBS).

What is necessary:

  1. Kubernetes cluster.
  2. Upstream tests, see the link above. Basically run ginkgo -focus=... in a specific kubernetes/kubernetes dir.
  3. Test manifest describing what to tests (see readme linked above, simple yaml file).

From the other tests in this repo, 1. and 3. look easy, however, getting upstream tests at point 2. may be complicated. Is tester/migration-test-config.yaml something similar?

/feature

@leakingtapan
Copy link
Contributor

leakingtapan commented Mar 23, 2020

Are you trying to test CSI migration with the k/k external test suites or test EBS CSI with the external test? Either way, the tester config file single-az-config.yaml, tells the tester what cluster to spin up and what test to run.

If you want to download k/k source and compile it, you could put it inside the test block before executing the e2e.test binary

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2020
@leakingtapan
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 24, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayberk
Copy link
Contributor

ayberk commented Jan 26, 2021

/reopen
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot reopened this Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

@ayberk: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
5 participants