Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it work with docker 23.x with CSI support? #1513

Closed
ieugen opened this issue Feb 16, 2023 · 7 comments
Closed

Does it work with docker 23.x with CSI support? #1513

ieugen opened this issue Feb 16, 2023 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ieugen
Copy link

ieugen commented Feb 16, 2023

Hi,

So docker 23.x was released with initial CSI support.
Is this the right place to "ask" about adding docker support for this plugin ?

Going through the issue It seems that CSI drivers should work out of the box if they are packaged for docker use.
See moby/moby#41982 (comment)

Basically, I've had to extract binaries from the images used by Kube or build those binaries from scratch and then build a Swarm CSI compatible Docker Plugin configuration. It's completely possible and doesn't require any changes in the CSI drivers, but I do have to start over from just the binaries.

There is some work relevant to this here https://github.com/olljanat/csi-plugins-for-docker-swarm

Release notes mention the github issues and what was released.
https://docs.docker.com/engine/release-notes/23.0/

Add experimental support for SwarmKit cluster volumes (CSI). moby/moby#41982
CLI: Add cluster volume (CSI) options to docker volume. docker/cli#3606
CLI: Add cluster volume (CSI) support to docker stack. docker/cli#3662

I am just a Docker user that would like to use EBS volumes with Docker.
I am opening this issue in the hope that it makes a difference.
I do imagine docker team can't handle everything on their own and it's something I would like to use.

Thanks,
Eugen

/triage support

@k8s-ci-robot
Copy link
Contributor

@ieugen: The label(s) triage/support cannot be applied, because the repository doesn't have them.

In response to this:

Hi,

So docker 23.x was released with initial CSI support.
Is this the right place to "ask" about adding docker support for this plugin ?

Going through the issue It seems that CSI drivers should work out of the box if they are packaged for docker use.
See moby/moby#41982 (comment)

Basically, I've had to extract binaries from the images used by Kube or build those binaries from scratch and then build a Swarm CSI compatible Docker Plugin configuration. It's completely possible and doesn't require any changes in the CSI drivers, but I do have to start over from just the binaries.

There is some work relevant to this here https://github.com/olljanat/csi-plugins-for-docker-swarm

Release notes mention the github issues and what was released.
https://docs.docker.com/engine/release-notes/23.0/

Add experimental support for SwarmKit cluster volumes (CSI). moby/moby#41982
CLI: Add cluster volume (CSI) options to docker volume. docker/cli#3606
CLI: Add cluster volume (CSI) support to docker stack. docker/cli#3662

I am just a Docker user that would like to use EBS volumes with Docker.
I am opening this issue in the hope that it makes a difference.
I do imagine docker team can't handle everything on their own and it's something I would like to use.

Thanks,
Eugen

/triage support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ConnorJC3
Copy link
Contributor

ConnorJC3 commented Feb 16, 2023

Hi @ieugen! Our driver is known to work on alternative container orchestrators such as Nomad and Cloud Foundry. As long as Docker Swarm implements the CSI specification correctly I see no reason the driver couldn't be used with it.

There is one downside: the driver needs to know what region it is running in. Today, we get that information from either IMDS or Kubernetes (we try both in parallel on startup). Obviously, when not running on Kubernetes that is not an option, so IMDS must be available to the driver to get the region from.

We likely won't provide any official documentation for Docker Swarm at the moment, but our official container image(s) are available in our README, and we have documentation about most of the driver's CLI paramaters. In theory, it should be as simple as setting up the driver using Docker's system.

Note that for obvious reasons we will not accept bug reports for non-standard quirks or bugs in Docker's implementation of CSI - those should be reported to the appropriate upstream. However, although our current bug report/feature request templates are geared towards Kubernetes we are willing to accept other issues as long as they are generally applicable to COs as a category rather than Docker Swarm specific.

@ieugen
Copy link
Author

ieugen commented Feb 23, 2023

Tracking here olljanat/csi-plugins-for-docker-swarm#12

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 23, 2023
@torredil
Copy link
Member

torredil commented Jul 3, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@torredil: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants