disk: attach disks with serial number at controller #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
huww98
force-pushed
the
disk-ad-controller-serial
branch
3 times, most recently
from
c1e5398 to
30d433a
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
needs-rebase
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
30d433a to
25da495
Compare
k8s-ci-robot
added
needs-rebase
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
25da495 to
a0e9edf
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
a0e9edf to
336bd7a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-rebase
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
336bd7a to
72d6526
Compare
k8s-ci-robot
removed
the
needs-rebase
|
based on #1330 |
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
72d6526 to
8b269b9
Compare
k8s-ci-robot
added
size/XXL
huww98
force-pushed
the
disk-ad-controller-serial
branch
3 times, most recently
from
057c8cb to
5b05b41
Compare
Don't assume the serial is the volume ID without "d-" prefix.
Eliminate the risk of finding the wrong disk. It may take a while for the disk device to appear after the OpenAPI returns in_use. e.g. when the previous detach is blocked, the attach will also be blocked.
Attach and detach must be migrated at once, because NodeUnstageVolume may be followed immediately by another NodeStageVolume, without controller actions. So if we detach disk at NodeUnstageVolume, NodeStageVolume will not find the disk. Note: user must upgrade controller before node, to avoid any missing detach. This is the first step to move all attach/detach back to controller, in order to: - reduce RAM permission on node - more effective request batching - rely less on node, which can be down - resolve some rare racing issue
huww98
force-pushed
the
disk-ad-controller-serial
branch
from
5b05b41 to
f598525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Attach and detach must be migrated at once, because NodeUnstageVolume may be followed immediately by anoterh NodeStageVolume, without controller actions.
So if we detach disk at NodeUnstageVolume, NodeStageVolume will not find the disk.
Note: user must upgrade controller before node, to avoid any missing detach.
This is the first step to move all attach/detach back to controller, in order to:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/hold
merge after #1087
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: