disk/CreateVolume: remove protection against repeated create

This protection is fragile, it cannot suvive CSI restart, and breaks the
detection of inconsistent create parameters between two requests with the same
name.

pkg/disk/controllerserver.go

@@ -123,16 +123,9 @@ func NewControllerServer(d *csicommon.CSIDriver, client *crd.Clientset) csi.Cont
 // the map of req.Name and csi.Snapshot
 var createdSnapshotMap = map[string]*csi.Snapshot{}
 
-// the map of req.Name and csi.Volume
-var createdVolumeMap = map[string]*csi.Volume{}
-
 // the map of multizone and index
 var storageClassZonePos = map[string]int{}
 
-// the map of diskId and pvName
-// diskId and pvName is not same under csi plugin
-var diskIDPVMap = map[string]string{}
-
 // SnapshotRequestMap snapshot request limit
 var SnapshotRequestMap = map[string]int64{}
 
@@ -148,10 +141,6 @@ func (cs *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
 		log.Log.Errorf("CreateVolume: driver not support Create volume: %v", err)
 		return nil, err
 	}
-	if value, ok := createdVolumeMap[req.Name]; ok {
-		log.Log.Infof("CreateVolume: volume already be created pvName: %s, VolumeId: %s, volumeContext: %v", req.Name, value.VolumeId, value.VolumeContext)
-		return &csi.CreateVolumeResponse{Volume: value}, nil
-	}
 
 	snapshotID := ""
 	volumeSource := req.GetVolumeContentSource()
@@ -252,8 +241,6 @@ func (cs *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
 
 	tmpVol := volumeCreate(diskType, diskID, volSizeBytes, volumeContext, diskVol.ZoneID, src)
 
-	diskIDPVMap[diskID] = req.Name
-	createdVolumeMap[req.Name] = tmpVol
 	return &csi.CreateVolumeResponse{Volume: tmpVol}, nil
 }
 
@@ -278,11 +265,6 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
 			log.Log.Error(errMsg)
 			return nil, status.Error(codes.Internal, errMsg)
 		} else if disk == nil {
-			// TODO Optimize concurrent access problems
-			if value, ok := diskIDPVMap[req.VolumeId]; ok {
-				delete(createdVolumeMap, value)
-				delete(diskIDPVMap, req.VolumeId)
-			}
 			log.Log.Infof("DeleteVolume: disk(%s) already deleted", req.VolumeId)
 			return &csi.DeleteVolumeResponse{}, nil
 		}
@@ -328,10 +310,6 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
 		return nil, status.Errorf(codes.Internal, errMsg)
 	}
 
-	if value, ok := diskIDPVMap[req.VolumeId]; ok {
-		delete(createdVolumeMap, value)
-		delete(diskIDPVMap, req.VolumeId)
-	}
 	delVolumeSnap.Delete(req.GetVolumeId())
 	return &csi.DeleteVolumeResponse{}, nil
 }